Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault Change #775

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Vault Change #775

merged 6 commits into from
Sep 30, 2024

Conversation

NPC1314
Copy link
Contributor

@NPC1314 NPC1314 commented Sep 22, 2024

About The Pull Request

Changes vault interest rate to 10% (was 25%)
Blacklists coin from gathering interest in vault

Will decrease the fountain of inflation that is the Keeps internal money stash.
Will increase the need to interact with outsiders such as craftsmen and drifters to get items, found or produced in general.
Obviously not a fix to the entire economy, still a hundred loopholes, one less.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@Mogelix
Copy link

Mogelix commented Sep 22, 2024

I'll give you mad head if you make it so that if you deposit more of the same item in the vault, you get diminishing returns from that type of item. I'm going to kill myself if I see Emerald Bromson spam making four hundred golden rings to sell to the king or merchant again.

@NPC1314
Copy link
Contributor Author

NPC1314 commented Sep 22, 2024

I'll give you mad head if you make it so that if you deposit more of the same item in the vault, you get diminishing returns from that type of item. I'm going to kill myself if I see Emerald Bromson spam making four hundred golden rings to sell to the king or merchant again.

All the rings are turbobroken in value, no economic activity comes close to making rings. Ringmaking is at least fifty times more profitable per time unit than say woodlogging, couple hundred times more efficient than farming etc. Its truly ludicrous.
That will be fixed when I implement the value defines so not far off. You will know its done when discord is filled with wails and crying.

What you describe (diminishing returns) should be fairly easy but I dont know if I have the energy to add it right now. It would reward diversity in the economy so good ( = incentive to not just rely on smith strat but also encourage engaging with drifters and farmers and whatnot)

@Mogelix
Copy link

Mogelix commented Sep 22, 2024

I'll give you mad head if you make it so that if you deposit more of the same item in the vault, you get diminishing returns from that type of item. I'm going to kill myself if I see Emerald Bromson spam making four hundred golden rings to sell to the king or merchant again.

All the rings are turbobroken in value, no economic activity comes close to making rings. Ringmaking is at least fifty times more profitable per time unit than say woodlogging, couple hundred times more efficient than farming etc. Its truly ludicrous. That will be fixed when I implement the value defines so not far off. You will know its done when discord is filled with wails and crying.

What you describe (diminishing returns) should be fairly easy but I dont know if I have the energy to add it right now. It would reward diversity in the economy so good ( = incentive to not just rely on smith strat but also encourage engaging with drifters and farmers and whatnot)

I'm glad you see the logic and not just my burning spite.

@Ickysoup
Copy link

This would be nice if you did something to make people want to play steward more. This is going to make playing a courtless king an even greater pain in the ass.

@AceVX
Copy link
Contributor

AceVX commented Sep 23, 2024

As a king player -- yes. I think it's needed. The inflation machine must be nerfed or money just stays as a bad joke.

@AceVX
Copy link
Contributor

AceVX commented Sep 27, 2024

Any word on this ?

Copy link
Contributor

@ThePainkiller ThePainkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really bad and ironic that coin on the vault doesn't add revenue because that's literally how a bank words. However, if it's for balance purposes out of players just inflating the economy like nothing, I think we can give this little concession for the sake of erasing cheesing methods. This also makes things mastercrafted by smiths (like masterwork statues and rings) to be more sought after due to their increased value.

@ThePainkiller ThePainkiller merged commit 0077aba into Darkrp-community:main Sep 30, 2024
3 checks passed
@NPC1314 NPC1314 deleted the vault branch October 9, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants